-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaExplicitOdeSolver] Introduce examples scenes #2199
[SofaExplicitOdeSolver] Introduce examples scenes #2199
Conversation
So it is more similar to the other signature functions. Suggestion by jnbrunet PR#2163
[ci-build][with-all-tests] |
# Conflicts: # SofaKernel/modules/SofaExplicitOdeSolver/src/SofaExplicitOdeSolver/EulerSolver.cpp # SofaKernel/modules/SofaExplicitOdeSolver/src/SofaExplicitOdeSolver/EulerSolver.h
[ci-build][with-all-tests] |
Now that #2165 is merged, I could remove the Data |
Two regression tests are failing :
I suppose this is because you moved them into a new folder and the Regression project has not been updated accordingly. |
@fredroy, yes it makes sense. Thanks for pointing it out. |
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #7. To unlock the merge button, you must
|
[ci-depends-on] detected during build #8. To unlock the merge button, you must
|
[ci-depends-on] detected during build #9. To unlock the merge button, you must
|
[ci-depends-on] detected during build #10. To unlock the merge button, you must
|
[ci-build][with-all-tests][force-full-build] |
[ci-depends-on] detected during build #11. To unlock the merge button, you must
|
[ci-depends-on] detected during build #12. To unlock the merge button, you must
|
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #13. To unlock the merge button, you must
|
Introduce examples scenes for 4 cases of Euler explicit solver:
I did my best to create stable scenes, but it is not that simple with an Euler explicit solver. Especially if not symplectic. It comes at the price of very small time step sizes.
This PR is based on #2163. It will need to be updated after #2165 is merged
[ci-depends-on https://github.com/sofa-framework/Regression/pull/15]