Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1677888, SNOW-1677890: Add support for DataFrame.tz_convert and Series.tz_convert #2399

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1677888, SNOW-1677890

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Add support for DataFrame.tz_convert and Series.tz_convert.

@sfc-gh-nkrishna
Copy link
Contributor

sfc-gh-nkrishna commented Oct 4, 2024

Edit based on Slack discussion: There are multiple subtle differences. For example, input to tz_localize needs to be tz-naive, while input to tz_convert needs to be tz-aware. Let's keep as separate PRs for now.

@sfc-gh-helmeleegy IMO the code in this PR can be added to the tz_localize one as well: #2398. I think you can even test both tz_localize/tz_convert by parametrizing on the function in the same test file. Even though the PR line diff it bloated, it will mostly be docstrings/signature and since most of the code is in both places, you will have to rebase anyways.

Copy link
Contributor

@sfc-gh-jkew sfc-gh-jkew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Looks good.

Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sfc-gh-helmeleegy sfc-gh-helmeleegy enabled auto-merge (squash) October 4, 2024 20:21
@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit 40baa95 into main Oct 4, 2024
36 of 37 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-1677890 branch October 4, 2024 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants