SNOW-1677892, SNOW-1677897: Add support for DataFrame.tz_localize and Series.tz_localize #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-helmeleegy
force-pushed
the
helmeleegy-SNOW-1677892
branch
2 times, most recently
from
6e17477
to
875581f
Compare
… Series.tz_localize
sfc-gh-helmeleegy
force-pushed
the
helmeleegy-SNOW-1677892
branch
from
875581f
to
7eb392b
Compare
sfc-gh-nkrishna
approved these changes
Oct 4, 2024
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
src/snowflake/snowpark/modin/plugin/compiler/snowflake_query_compiler.py
Outdated
Show resolved
Hide resolved
7 tasks
sfc-gh-jjiao
reviewed
Oct 4, 2024
| @@ -483,7 +483,8 @@ Methods | |||
| +-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+ | |||
| | ``tz_convert`` | N | | | | |||
| +-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+ | |||
| | ``tz_localize`` | N | | | | |||
| | ``tz_localize`` | P | ``axis``, ``level``, ``copy``, | | | |||
| | | | ``ambiguous``, ``nonexistent`` | | | |||
There was a problem hiding this comment.
qq: how did we determine what parameters are going to be skipped (not implemented)? what's the process / criteria?
There was a problem hiding this comment.
Good question. Initially, we want to make sure we are supporting all the default values (for parameters that do have default values). The parameter tz here for instance does not have a default value, so it has to be fully supported.
We can later add more parameter coverage, which usually happens based on customer requests. The rationale is that default values are typically the most commonly used by users.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1677892, SNOW-1677897
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add support for DataFrame.tz_localize and Series.tz_localize.