Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added better error when docker is not installed #1191

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Added better error when docker is not installed #1191

merged 1 commit into from
Jun 12, 2024

Conversation

sfc-gh-astus
Copy link
Collaborator

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Improved error message in snow spcs image-registry login when docker is not installed.

@sfc-gh-astus sfc-gh-astus requested a review from a team as a code owner June 12, 2024 08:33
sfc-gh-pczajka
sfc-gh-pczajka previously approved these changes Jun 12, 2024
View reviewed changes
@sfc-gh-astus sfc-gh-astus force-pushed the better-error-when-docker-is-not-installed branch from acf0a84 to a175954 Compare June 12, 2024 09:58
@sfc-gh-turbaszek sfc-gh-turbaszek linked an issue Jun 12, 2024 that may be closed by this pull request
SNOW-1444835: snow spcs image-registry login should give functional error if docker is not installed #1102
Closed
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit ed61857 into main Jun 12, 2024
24 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the better-error-when-docker-is-not-installed branch June 12, 2024 10:13
sfc-gh-turbaszek added a commit that referenced this pull request Jun 12, 2024
@sfc-gh-turbaszek
fixup! Added better error when docker is not installed (#1191)
e26eade
sfc-gh-turbaszek added a commit that referenced this pull request Jun 12, 2024
@sfc-gh-turbaszek
fixup! fixup! Added better error when docker is not installed (#1191)
bd5b50f
sfc-gh-turbaszek added a commit that referenced this pull request Jun 12, 2024
@sfc-gh-turbaszek
fixup! fixup! fixup! Added better error when docker is not installed (#…
667553d 
…1191)
sfc-gh-turbaszek added a commit that referenced this pull request Jul 9, 2024
@sfc-gh-turbaszek
fixup! Added better error when docker is not installed (#1191)
5c74551
sfc-gh-turbaszek added a commit that referenced this pull request Jul 9, 2024
@sfc-gh-turbaszek
fixup! fixup! Added better error when docker is not installed (#1191)
3d3bd85
sfc-gh-turbaszek added a commit that referenced this pull request Jul 9, 2024
@sfc-gh-turbaszek
fixup! fixup! fixup! Added better error when docker is not installed (#…
cc1a295 
…1191)
sfc-gh-turbaszek added a commit that referenced this pull request Jul 9, 2024
@sfc-gh-turbaszek
fixup! fixup! fixup! fixup! Added better error when docker is not ins…
7d56630 
…talled (#1191)
sfc-gh-turbaszek added a commit that referenced this pull request Jul 9, 2024
@sfc-gh-turbaszek
fixup! fixup! fixup! fixup! fixup! Added better error when docker is …
0d8d20e 
…not installed (#1191)
sfc-gh-turbaszek added a commit that referenced this pull request Jul 9, 2024
@sfc-gh-turbaszek
fixup! fixup! fixup! fixup! fixup! fixup! Added better error when doc…
9fa1732 
…ker is not installed (#1191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

@sfc-gh-pczajka sfc-gh-pczajka sfc-gh-pczajka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-1444835: snow spcs image-registry login should give functional error if docker is not installed
3 participants
@sfc-gh-astus @sfc-gh-turbaszek @sfc-gh-pczajka