Skip to content

Commit

Permalink
fixup! fixup! fixup! fixup! fixup! fixup! Added better error when doc…
Browse files Browse the repository at this point in the history 
…ker is not installed (#1191)
  • Loading branch information
@sfc-gh-turbaszek
sfc-gh-turbaszek committed Jul 9, 2024
1 parent 0d8d20e commit 9fa1732
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 40 deletions.
3 changes: 1 addition & 2 deletions src/snowflake/cli/plugins/stage/manager.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ def _filter_files_list(
return filtered_files
else:
raise ClickException(
f"Invalid file extension, only {','.join(EXECUTE_SUPPORTED_FILES_FORMATS)} files are allowed."
f"Invalid file extension, only {', '.join(EXECUTE_SUPPORTED_FILES_FORMATS)} files are allowed."
)
# Filter with fnmatch if contains `*` or `?`
if glob.has_magic(stage_path):
Expand Down Expand Up @@ -377,7 +377,6 @@ def _call_execute_immediate(
if variables:
query += variables
self._execute_query(query)
cli_console.step(f"SUCCESS - {file_stage_path}")
return StageManager._success_result(file=file_stage_path)
except ProgrammingError as e:
StageManager._handle_execution_exception(on_error=on_error, exception=e)
Expand Down
38 changes: 0 additions & 38 deletions tests/stage/__snapshots__/test_stage.ambr
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,8 @@
# name: test_execute[@db.schema.exe-@db.schema.exe-expected_files15]
'''
SUCCESS - @db.schema.exe/s1.sql
SUCCESS - @db.schema.exe/s1.sql
SUCCESS - @db.schema.exe/a/s3.sql
SUCCESS - @db.schema.exe/a/s3.sql
SUCCESS - @db.schema.exe/a/b/s4.sql
SUCCESS - @db.schema.exe/a/b/s4.sql
+---------------------------------------------+
| File | Status | Error |
|---------------------------+---------+-------|
Expand All @@ -44,7 +41,6 @@
# name: test_execute[@db.schema.exe/s1.sql-@db.schema.exe-expected_files17]
'''
SUCCESS - @db.schema.exe/s1.sql
SUCCESS - @db.schema.exe/s1.sql
+-----------------------------------------+
| File | Status | Error |
|-----------------------+---------+-------|
Expand All @@ -56,10 +52,7 @@
# name: test_execute[@exe-@exe-expected_files0]
'''
SUCCESS - @exe/s1.sql
SUCCESS - @exe/s1.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
Expand All @@ -74,10 +67,7 @@
# name: test_execute[db.schema.exe-@db.schema.exe-expected_files16]
'''
SUCCESS - @db.schema.exe/s1.sql
SUCCESS - @db.schema.exe/s1.sql
SUCCESS - @db.schema.exe/a/s3.sql
SUCCESS - @db.schema.exe/a/s3.sql
SUCCESS - @db.schema.exe/a/b/s4.sql
SUCCESS - @db.schema.exe/a/b/s4.sql
+---------------------------------------------+
| File | Status | Error |
Expand All @@ -92,11 +82,8 @@
# name: test_execute[exe-@exe-expected_files1]
'''
SUCCESS - @exe/s1.sql
SUCCESS - @exe/s1.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
|-----------------+---------+-------|
Expand All @@ -110,11 +97,8 @@
# name: test_execute[exe/*-@exe-expected_files3]
'''
SUCCESS - @exe/s1.sql
SUCCESS - @exe/s1.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
|-----------------+---------+-------|
Expand All @@ -128,10 +112,7 @@
# name: test_execute[exe/*.sql-@exe-expected_files4]
'''
SUCCESS - @exe/s1.sql
SUCCESS - @exe/s1.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
Expand All @@ -146,11 +127,8 @@
# name: test_execute[exe/-@exe-expected_files2]
'''
SUCCESS - @exe/s1.sql
SUCCESS - @exe/s1.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
|-----------------+---------+-------|
Expand All @@ -164,8 +142,6 @@
# name: test_execute[exe/a-@exe-expected_files5]
'''
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
Expand All @@ -179,8 +155,6 @@
# name: test_execute[exe/a/*-@exe-expected_files7]
'''
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
Expand All @@ -194,8 +168,6 @@
# name: test_execute[exe/a/*.sql-@exe-expected_files8]
'''
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
Expand All @@ -209,8 +181,6 @@
# name: test_execute[exe/a/-@exe-expected_files6]
'''
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/s3.sql
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
Expand All @@ -224,7 +194,6 @@
# name: test_execute[exe/a/b-@exe-expected_files9]
'''
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
|-----------------+---------+-------|
Expand All @@ -236,7 +205,6 @@
# name: test_execute[exe/a/b/*-@exe-expected_files11]
'''
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
|-----------------+---------+-------|
Expand All @@ -248,7 +216,6 @@
# name: test_execute[exe/a/b/*.sql-@exe-expected_files12]
'''
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
|-----------------+---------+-------|
Expand All @@ -260,7 +227,6 @@
# name: test_execute[exe/a/b/-@exe-expected_files10]
'''
SUCCESS - @exe/a/b/s4.sql
SUCCESS - @exe/a/b/s4.sql
+-----------------------------------+
| File | Status | Error |
|-----------------+---------+-------|
Expand All @@ -272,7 +238,6 @@
# name: test_execute[exe/s1.sql-@exe-expected_files14]
'''
SUCCESS - @exe/s1.sql
SUCCESS - @exe/s1.sql
+-------------------------------+
| File | Status | Error |
|-------------+---------+-------|
Expand All @@ -284,7 +249,6 @@
# name: test_execute[exe/s?.sql-@exe-expected_files13]
'''
SUCCESS - @exe/s1.sql
SUCCESS - @exe/s1.sql
+-------------------------------+
| File | Status | Error |
|-------------+---------+-------|
Expand All @@ -298,10 +262,8 @@
SUCCESS - @exe/p1.py
FAILURE - @exe/p2.py
SUCCESS - @exe/s1.sql
SUCCESS - @exe/s1.sql
FAILURE - @exe/s2.sql
SUCCESS - @exe/s3.sql
SUCCESS - @exe/s3.sql
+------------------------------------+
| File | Status | Error |
|-------------+---------+------------|
Expand Down

0 comments on commit 9fa1732

Please sign in to comment.