Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/chains/cosmos/cosmostxm: simplifications #11101

Merged
merged 1 commit into from
Oct 30, 2023
Merged

core/chains/cosmos/cosmostxm: simplifications #11101

merged 1 commit into from
Oct 30, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 26, 2023 •
edited
Loading

  • unexport keystoreAdapter
  • rm unnecessary package *_test suffixes
  • rm unnecessary test helpers

Requires:

@jmank88 jmank88 requested a review from a team October 26, 2023 22:58
@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 force-pushed the cosmos-simple branch 2 times, most recently from aa006de to 5f38fe0 Compare October 26, 2023 23:07
@jmank88
Copy link
Contributor Author

jmank88 commented Oct 27, 2023

This is tangled up on an import cycle. Easier to do after or while moving the config over to chainlink-cosmos.

cfal
cfal previously approved these changes Oct 27, 2023
View reviewed changes
@jmank88 jmank88 mentioned this pull request Oct 27, 2023
Merged
@jmank88 jmank88 requested review from a team, jkongie and samsondav as code owners October 27, 2023 02:15
@jmank88 jmank88 force-pushed the cosmos-simple branch 2 times, most recently from b8cb669 to d5ceaa4 Compare October 27, 2023 11:37
@jmank88 jmank88 force-pushed the cosmos-simple branch 2 times, most recently from 634f7be to e69ef85 Compare October 27, 2023 22:08
krehermann
krehermann previously approved these changes Oct 30, 2023
View reviewed changes
@jmank88 jmank88 force-pushed the cosmos-simple branch 2 times, most recently from 54b99dc to 4a0c298 Compare October 30, 2023 14:04
@jmank88 jmank88 force-pushed the cosmos-simple branch 2 times, most recently from 1d22d85 to c593eb4 Compare October 30, 2023 14:39
@jmank88 jmank88 force-pushed the cosmos-simple branch 3 times, most recently from b1b5ab3 to b1299d5 Compare October 30, 2023 16:10
krehermann
krehermann previously approved these changes Oct 30, 2023
View reviewed changes
@jmank88 jmank88 added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 30, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

76.0% 76.0% Coverage
0.0% 0.0% Duplication

@jmank88 jmank88 added this pull request to the merge queue Oct 30, 2023
Merged via the queue into develop with commit e3caf76 Oct 30, 2023
84 checks passed
@jmank88 jmank88 deleted the cosmos-simple branch October 30, 2023 18:31
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann approved these changes

@archseer archseer Awaiting requested review from archseer

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@aalu1418 aalu1418 Awaiting requested review from aalu1418

@cfal cfal Awaiting requested review from cfal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @cfal @krehermann