Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/cosmos/config: mv config from core #380

Merged
merged 1 commit into from
Oct 30, 2023
Merged

pkg/cosmos/config: mv config from core #380

merged 1 commit into from
Oct 30, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 27, 2023 •
edited
Loading

Move config from core, which requires bumping chainlink-relay, which comes with Go 1.21.

Supports:

@jmank88 jmank88 mentioned this pull request Oct 27, 2023
Merged
@jmank88 jmank88 force-pushed the mv-config branch 2 times, most recently from a159751 to efd7562 Compare October 27, 2023 02:07
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 9.2% 9.2% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@jmank88 jmank88 marked this pull request as ready for review October 27, 2023 12:17
aalu1418
aalu1418 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving + merging to unblock core extraction - broken gauntlet + contract tests will be revisited in the future

@aalu1418 aalu1418 merged commit 81a5a89 into develop Oct 30, 2023
9 of 16 checks passed
@aalu1418 aalu1418 deleted the mv-config branch October 30, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann approved these changes

@aalu1418 aalu1418 aalu1418 approved these changes

@cfal cfal Awaiting requested review from cfal

@archseer archseer Awaiting requested review from archseer

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @krehermann @aalu1418