Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ccip helm chart to use ccip-scripts for contract deployment #614
Extend ccip helm chart to use ccip-scripts for contract deployment #614
Changes from 11 commits
de97dcc
6182b8c
2c65545
6618ce4
a7311b1
0f6a254
dd145dd
bf44746
c99936d
b05115c
826309b
8c6902a
30f46b1
28bb5fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skudasov the job to deploy contracts and other ccip stuff would run here as helm post-install hook.
Running the job is optional and controlled by
$.Values.ccip.deployContractsAndJobs
flag.So if there are other use case they can disable it via that flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally the nodes themselves should have a readiness probe, and we could rely on that for sequencing the deployment. But this can work as some extra protection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleaning up deprecated reference to runner pods