Extend ccip helm chart to use ccip-scripts for contract deployment #614
Conversation
|
|
||
| ccip: | ||
| chains: | ||
| - NetworkId: 1337 |
There was a problem hiding this comment.
values here are an example values based on the ccip-scripts example input.json from @AnieeG
scheibinger
force-pushed
the
ccip-scripts-helm
branch
from
27347e1
to
73985f0
Compare
scheibinger
force-pushed
the
ccip-scripts-helm
branch
from
73985f0
to
d4514c3
Compare
scheibinger
changed the title
| @@ -120,8 +120,8 @@ geth: | |||
| runAsUser: 999 | |||
| runAsGroup: 999 | |||
| version: v1.12.0 | |||
| wsrpc-port: 8546 | |||
| httprpc-port: 8544 | |||
There was a problem hiding this comment.
these weren't used anywhere and they were causing issues in helm templates, as it doesn't like dashes. I renamed to camel case
scheibinger
force-pushed
the
ccip-scripts-helm
branch
from
4ee2297
to
16a9e2f
Compare
to match the latest structure from ccip-scripts repo Fix json syntax errors
scheibinger
force-pushed
the
ccip-scripts-helm
branch
from
205b128
to
c99936d
Compare
| annotations: | ||
| prometheus.io/scrape: 'true' | ||
| spec: | ||
| initContainers: |
There was a problem hiding this comment.
ideally the nodes themselves should have a readiness probe, and we could rely on that for sequencing the deployment. But this can work as some extra protection.
| # Allow all runner pods to access the database pods. | ||
| - podSelector: | ||
| matchLabels: | ||
| app: runner |
There was a problem hiding this comment.
cleaning up deprecated reference to runner pods
There was a problem hiding this comment.
Looks great! The biggest thing is making sure that changes like value name casing is synced on the /chainlink repo too to avoid pain. Are there any values that we should update in Argo too in order to use this? If so, that would be a separate PR on the GitOps repo.
charts/chainlink-cluster/templates/mockserver-networkpolicy.yaml
Outdated
Show resolved
Hide resolved
| # This is what defines this resource as a hook. Without this line, the | ||
| # job is considered part of the release. | ||
| "helm.sh/hook": post-install,post-upgrade | ||
| "helm.sh/hook-weight": "0" |
There was a problem hiding this comment.
@skudasov the job to deploy contracts and other ccip stuff would run here as helm post-install hook.
Running the job is optional and controlled by $.Values.ccip.deployContractsAndJobs flag.
So if there are other use case they can disable it via that flag.
Co-authored-by: chainchad <96362174+chainchad@users.noreply.github.com>
scheibinger
added
crib
Motivation
Enable automated E2E testing via providing a workflow to automate deployment of ccip contracts and jobs within devspace/helm setup.
Solution
Added a batch job that will install scripts and contracts as part of
helm install/upgradecommand.To provide more context I posted GH comments alongside the source code