Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop bundler before restart the process #675

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

carvinlo
Copy link
Contributor

@carvinlo carvinlo commented Feb 9, 2024

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

fix 671

Remarks

[Optionally place any follow-up comments, remarks, observations, or notes here for future reference]

Copy link

github-actions bot commented Feb 9, 2024

File size impact

Merging develop-fix-multi-build into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 30.2 kB (0 B / +0%) 👻
Total (2) 30.2 kB (0 B / +0%) 👻
minimal-piral (no impact)
Files new size
Unmodified (2) 277 kB (0 B / +0%) 👻
Total (2) 277 kB (0 B / +0%) 👻
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.22 MB (0 B / +0%) 👻
Total (3) 2.22 MB (0 B / +0%) 👻
sample-piral (no impact)
Files new size
Unmodified (3) 696 kB (0 B / +0%) 👻
Total (3) 696 kB (0 B / +0%) 👻
sample-piral-core (no impact)
Files new size
Unmodified (3) 354 kB (0 B / +0%) 👻
Total (3) 354 kB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during check-bundle-size#7846029465 on 00d9c19

Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a great point. In debug-piral.ts we actually do this and stop here, here we don't. Thanks for spotting (and fixing!) this inconsistency.

You rock! 🚀

@FlorianRappl FlorianRappl added this to the 1.5.0 milestone Feb 9, 2024
@FlorianRappl FlorianRappl added bug Something isn't working cli Concerns the piral-cli application. labels Feb 9, 2024
@FlorianRappl FlorianRappl merged commit 973dddf into smapiot:develop Feb 9, 2024
6 checks passed
@carvinlo carvinlo deleted the develop-fix-multi-build branch April 11, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Concerns the piral-cli application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the app-shell example debugging mode, saving package.json will prompt that the port is used
2 participants