-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the app-shell example debugging mode, saving package.json will prompt that the port is used #671
Comments
Thanks for the report. A fix for this is out with the latest preview ( |
I tested and it was fixed, thank you! |
There are the same problem with using Environment Details and Version Expected behavior Actual behavior
![]() |
We restart the process independent of what the bundler does. So in case of Webpack it might be sensitive to the package.json, however, this is nothing we control or will change. If this edge case really impacts you (how?) then configure webpack to ignore the package.json. I think this is rather a cosmetic issue and for reliability it makes more sense that we restart the process than having just a single build here. |
I completely agree with your idea, but the repeated build may be related to not restarting webpack when restarting the pilet process. After testing, pr fixed this problem. But since I don’t fully understand the logic of |
Actually it is very reasonable. Thanks for spotting - with my answer I thought we already spot it and what you see is the triggering beforehand, but actually the bundler process keeps on running. Perfect PR - wonderful! |
Bug Report
For more information, see the
CONTRIBUTING
guide.Prerequisites
Environment Details and Version
Description
In the app-shell example debugging mode, saving package.json will prompt that the port is used. Continue to save component files, webpack will perform multiple compilations
Steps to Reproduce
yarn && yarn build && cd src/samples/minimal-piral && npx -y piral debug
command + s
shortcut key to save thesrc/samples/minimal-piral/package.json
fileExpected behavior
Actual behavior
Possible Origin/Solution
Is the piral-cli watcher did not reset the hmr watcher when restarting the pilet build? Some vscode plug-ins will modify package.json, thereby triggering the execution of the piral-cli watcher callback function?
The text was updated successfully, but these errors were encountered: