Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for loading signing keys from Key Vault #533 #660

Closed
wants to merge 1 commit into from

Conversation

berendhaan
Copy link

This feature can be enabled by setting TokenSigningConfiguration.UseAzureKeyVault to true and adding the following configuration options in the appsettings.json.

"AzureKeyVaultConfiguration": {
       "KeyVaultUri": "",
        "KeyName": ""
}

Some remarks:

  • There is no caching of the keys
  • Needs explanation how to configure Key Vault correctly
  • Not battle-tested, at the moment max 3 users and signing in a couple of times a week

@skoruba
Copy link
Owner

skoruba commented Oct 28, 2020

Hi @berendhaan - thank you for your PR, I've decided to load certificate from Azure KV on application startup currently - that is the reason why I am closing this PR. Thank you for your effort on this PR.

@skoruba skoruba closed this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants