Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for loading signing key from Azure Key Vault #533

Open
skoruba opened this issue Mar 11, 2020 · 3 comments
Open

Add support for loading signing key from Azure Key Vault #533

skoruba opened this issue Mar 11, 2020 · 3 comments
Assignees
@skoruba
Labels
priority: high task Task

Comments

@skoruba
Copy link
Owner

skoruba commented Mar 11, 2020

Add support for loading signing key from Azure Key Vault

Check this sample code:
damienbod/IdentityServer4AspNetCoreIdentityTemplate#30
@skoruba skoruba self-assigned this Mar 11, 2020
@berendhaan
Copy link

@skoruba We have incorporated Azure Kv generated signing keys in our installation of your (magnificent) admin UI.
It it still rough and needs some more configuration options, but it could be a start for you. Shall I create a PR so you can have look?

@skoruba
Copy link
Owner Author

skoruba commented Jul 24, 2020

@berendhaan - I would be perfect, could you please send a PR from dev branch?
Thanks!

berendhaan added a commit to berendhaan/IdentityServer4.Admin that referenced this issue Jul 24, 2020
@berendhaan
Add implementation for loading signing keys from Key Vault skoruba#533
0358a47
@berendhaan
Copy link

Done! #660
I've cleaned some stuff up before I made the PR. Haven't tested this implementation but it should work since nothing major was changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoruba skoruba

Labels
priority: high task Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@berendhaan @skoruba