Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKALED-1900 release build with separate debug info #1969

Open
wants to merge 10 commits into
base: v3.20.0
Choose a base branch
from
Open

SKALED-1900 release build with separate debug info #1969

wants to merge 10 commits into from

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Aug 23, 2024 •
edited
Loading

  1. All dependencies, are built with -O3 and without -g.
  2. skaled is built with -O3 but WITH -g.
  3. -rdynamic removed.
  4. skaled binary is stripped, but it's copy wit hdebug info is kept.

CUSTOM BUILD Now contains option to build maximally optimized "Release" configuration

Testing:
1

objdump -h skaled | grep debug
nm -a skaled

2 Execute strip command on skaled and see that it's size didn't change
3 ojdump -h <file> | grep debug on all project libraries shows no result too.

skaled binary size 29575576

Consequences:

  1. Stack trace printed by skaled on crash will not contain any function names.
  2. gdb will be able to use skaled-debug file to load debug info for original skaled
  3. addr2line will be able to convert addresses from skaled's printed stack trace into source code locations using skaled-debug binary

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@dimalit dimalit mentioned this pull request Aug 23, 2024
Closed
@dimalit dimalit changed the title Enhancement/skaled 1900 release build debug info SKALED-1900 release build with separate debug info Aug 23, 2024
@dimalit dimalit linked an issue Aug 28, 2024 that may be closed by this pull request
Remove debug library builds from release #1900
Open
@dimalit dimalit marked this pull request as ready for review August 28, 2024 17:28
olehnikolaiev
olehnikolaiev reviewed Aug 30, 2024
View reviewed changes
.github/workflows/publish.yml
@@ -28,6 +28,7 @@ jobs:
run: |
sudo apt-get -y remove libzmq* || true
sudo apt-get -y install software-properties-common gcc-9 g++-9 || true
sudo apt-get -y install liblz4-dev || true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can add this library to our deps script instead of installing in through apt-get? seems like it is pretty easy to install https://github.com/lz4/lz4

@kladkogex kladkogex self-requested a review August 30, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olehnikolaiev olehnikolaiev olehnikolaiev left review comments

@DmytroNazarenko DmytroNazarenko Awaiting requested review from DmytroNazarenko DmytroNazarenko is a code owner

@kladkogex kladkogex Awaiting requested review from kladkogex kladkogex is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove debug library builds from release
3 participants
@dimalit @kladkogex @olehnikolaiev