Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug library builds from release #1900

Open
kladkogex opened this issue May 16, 2024 · 1 comment · May be fixed by #1969
Open

Remove debug library builds from release #1900

kladkogex opened this issue May 16, 2024 · 1 comment · May be fixed by #1969
Assignees
@dimalit
Labels
Technical debt
Milestone
SKALE 3.1

Comments

@kladkogex
Copy link
Collaborator

kladkogex commented May 16, 2024 •
edited
Loading

It looks like the release build includes some libraries in debug (ZeroMQ) mode.

This needs to be fixed since it may affects performance

We need a check at the end of the build that the executable does not have debug symbols

image
@kladkogex kladkogex added the bug Something isn't working label May 16, 2024
@kladkogex kladkogex added this to the SKALE 2.5 milestone May 16, 2024
@kladkogex kladkogex assigned kladkogex and dimalit and unassigned dimalit and kladkogex May 16, 2024
@DmytroNazarenko DmytroNazarenko added Technical debt and removed bug Something isn't working labels Aug 7, 2024
@dimalit
Copy link
Contributor

dimalit commented Aug 7, 2024

Stan, we use RelsWithDeb info build type, so debug symbols are expected.

This was linked to pull requests Aug 23, 2024
SKALED-1900 Release build #1967
Closed
SKALED-1900 release build with separate debug info #1969
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimalit dimalit

Labels
Technical debt
Projects
SKALE Engineering 🚀
Status: Code Review
Milestone
SKALE 3.1
3 participants
@dimalit @kladkogex @DmytroNazarenko