-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename back to Sirupsen/logrus #570
Comments
Yes, original rename was a perfect failure. |
Any ETA? I was just gliding again and again and again |
@elaijuh adding lowercase package and
|
i was seeing this
oh that was glide cache problem though now glide helps to resolve the dep like this
|
@vearutop it won't help if you are running OS with case-insensitive filesystem (macOS by default and Windows are). |
See answer here #566 (comment) as well. I feel powerless, guilty, and deeply ashamed. I have not worked enough with Go in the past few years, and thus this decision was not taken with enough care. This is the root of why this has gone awry. At this point, I am fairly convinced a revert will make things worse. Keep in mind this is only breaking for people with mixed imports. Upper-case continues to work in projects that don't mix case. Every library should use lower-case to avoid this problem. I am actively engaging now with prospective maintainers who can provide better stewardship of Logrus than I have been able to provide. Before the rename, many people used Logrus with a lower-case import, because it happened to also work. Internally and in the projects I've been engaged with that use Logrus, lower-case imports have dominated. I was swayed by this availability bias. Before making this decision, data should've been gathered for the final direction (force lower-case, or force upper-case) and the other method actively deprecated. I do know many struggled with the uppercase variant, but it is possible the better course of action would've been to work at workarounds there and kill the lower-case altogether. Of course, those benefitting from the change will not be active here (but I am fairly convinced fewer people benefit from the change, than it negatively affects, thus the regret). For the record, the original proposal was in this PR: #384. Note also that it's not the rename of my handle from Only people who are importing projects that also use Logrus, where both mix cases are causing issues. This is the vast minority, but those dealing with it—I understand it's frustrating. I hope, at least, this will serve a greater lesson to the Go community and never happen again. This was, unfortunately, bound to happen at some point that someone would be careless enough to do what was done here. I am confident that this project will come out better because of it:
An abbreviated timeline of this issue:
|
Ugh, we have major issues even when using https://github.com/golang/dep
I'm on MacOS, which has case-insensitive file system. Well, even EDIT: I figured it out. For anyone interested (and using https://github.com/golang/dep), I had to:
|
I ran `govendor status` to check the integrity of vendored packages and found that the vendored copy of the logrus library did not match the version pinned in `vendor.json`. govendor gave the following error: $ govendor status The following packages are missing or modified locally: github.com/Sirupsen/logrus Error: status failed for 1 package(s) Additionally, remove the unused lowercase variant of logrus from `vendor.json`. The URL for this library changed upstream to use lowercase `sirupsen` instead of `Sirupsen`. The best way forward for now is to continue to use the uppercase version as that's what's used by the Prometheus libraries; mixed-case imports result in an import collision: can't load package: package github.com/sirupsen/logrus: case-insensitive import collision: "github.com/Sirupsen/logrus" and "github.com/sirupsen/logrus" See this comment for more details: sirupsen/logrus#570 (comment)
I ran `govendor status` to check the integrity of vendored packages and found that the vendored copy of the logrus library did not match the version pinned in `vendor.json`. govendor gave the following error: $ govendor status The following packages are missing or modified locally: github.com/Sirupsen/logrus Error: status failed for 1 package(s) Additionally, remove the unused lowercase variant of logrus from `vendor.json`. The URL for this library changed upstream to use lowercase `sirupsen` instead of `Sirupsen`. The best way forward for now is to continue to use the uppercase version as that's what's used by the Prometheus libraries; mixed-case imports result in an import collision: can't load package: package github.com/sirupsen/logrus: case-insensitive import collision: "github.com/Sirupsen/logrus" and "github.com/sirupsen/logrus" See this comment for more details: sirupsen/logrus#570 (comment)
This also fixes the bug on case-sensitive package naming. See these links: sirupsen/logrus#553 (comment) sirupsen/logrus#570 (comment)
I too am dealing with fallout from this issue. go: gitlab.com/msvechla/vaultbeat imports |
check more info at sirupsen/logrus#570
Automatic merge from submit-queue (batch tested with PRs 51186, 50350, 51751, 51645, 51837) Update Cadvisor Dependency Fixes: kubernetes/kubernetes#51832 This is the worst dependency update ever... The root of the problem is the [name change of Sirupsen -> sirupsen](sirupsen/logrus#570 (comment)). This means that in order to update cadvisor, which venders the lowercase, we need to update all dependencies to use the lower-cased version. With that being said, this PR updates the following packages: `github.com/docker/docker` - `github.com/docker/distribution` - `github.com/opencontainers/go-digest` - `github.com/opencontainers/image-spec` - `github.com/opencontainers/runtime-spec` - `github.com/opencontainers/selinux` - `github.com/opencontainers/runc` - `github.com/mrunalp/fileutils` - `golang.org/x/crypto` - `golang.org/x/sys` - `github.com/docker/go-connections` - `github.com/docker/go-units` - `github.com/docker/libnetwork` - `github.com/docker/libtrust` - `github.com/sirupsen/logrus` - `github.com/vishvananda/netlink` `github.com/google/cadvisor` - `github.com/euank/go-kmsg-parser` `github.com/json-iterator/go` Fixed kubernetes/kubernetes#51832 ```release-note Fix journalctl leak on kubelet restart Fix container memory rss Add hugepages monitoring support Fix incorrect CPU usage metrics with 4.7 kernel Add tmpfs monitoring support ``` Kubernetes-commit: 99aa992ce845fe947a406ac4d3f99d2208f0416b
Automatic merge from submit-queue (batch tested with PRs 51186, 50350, 51751, 51645, 51837) Update Cadvisor Dependency Fixes: kubernetes/kubernetes#51832 This is the worst dependency update ever... The root of the problem is the [name change of Sirupsen -> sirupsen](sirupsen/logrus#570 (comment)). This means that in order to update cadvisor, which venders the lowercase, we need to update all dependencies to use the lower-cased version. With that being said, this PR updates the following packages: `github.com/docker/docker` - `github.com/docker/distribution` - `github.com/opencontainers/go-digest` - `github.com/opencontainers/image-spec` - `github.com/opencontainers/runtime-spec` - `github.com/opencontainers/selinux` - `github.com/opencontainers/runc` - `github.com/mrunalp/fileutils` - `golang.org/x/crypto` - `golang.org/x/sys` - `github.com/docker/go-connections` - `github.com/docker/go-units` - `github.com/docker/libnetwork` - `github.com/docker/libtrust` - `github.com/sirupsen/logrus` - `github.com/vishvananda/netlink` `github.com/google/cadvisor` - `github.com/euank/go-kmsg-parser` `github.com/json-iterator/go` Fixed kubernetes/kubernetes#51832 ```release-note Fix journalctl leak on kubelet restart Fix container memory rss Add hugepages monitoring support Fix incorrect CPU usage metrics with 4.7 kernel Add tmpfs monitoring support ``` Kubernetes-commit: 99aa992ce845fe947a406ac4d3f99d2208f0416b
Automatic merge from submit-queue (batch tested with PRs 51186, 50350, 51751, 51645, 51837) Update Cadvisor Dependency Fixes: kubernetes/kubernetes#51832 This is the worst dependency update ever... The root of the problem is the [name change of Sirupsen -> sirupsen](sirupsen/logrus#570 (comment)). This means that in order to update cadvisor, which venders the lowercase, we need to update all dependencies to use the lower-cased version. With that being said, this PR updates the following packages: `github.com/docker/docker` - `github.com/docker/distribution` - `github.com/opencontainers/go-digest` - `github.com/opencontainers/image-spec` - `github.com/opencontainers/runtime-spec` - `github.com/opencontainers/selinux` - `github.com/opencontainers/runc` - `github.com/mrunalp/fileutils` - `golang.org/x/crypto` - `golang.org/x/sys` - `github.com/docker/go-connections` - `github.com/docker/go-units` - `github.com/docker/libnetwork` - `github.com/docker/libtrust` - `github.com/sirupsen/logrus` - `github.com/vishvananda/netlink` `github.com/google/cadvisor` - `github.com/euank/go-kmsg-parser` `github.com/json-iterator/go` Fixed kubernetes/kubernetes#51832 ```release-note Fix journalctl leak on kubelet restart Fix container memory rss Add hugepages monitoring support Fix incorrect CPU usage metrics with 4.7 kernel Add tmpfs monitoring support ``` Kubernetes-commit: 99aa992ce845fe947a406ac4d3f99d2208f0416b
Ay, a lot of projects are now broken after changing the casing of this project's git repository name. Docker/Moby, for example, can no longer be installed via glide, due to the Sirupsen/logrus 404.
The text was updated successfully, but these errors were encountered: