Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace use of the deprecated ioutil package #3

Merged
merged 9 commits into from
Jan 6, 2022
Merged

refactor: replace use of the deprecated ioutil package #3

merged 9 commits into from
Jan 6, 2022

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Nov 16, 2021 •
edited
Loading

Wait for #5 to be merged

@EtienneM EtienneM requested review from brandon-welsch and removed request for brandon-welsch November 16, 2021 17:38
@EtienneM EtienneM marked this pull request as draft November 16, 2021 17:38
@TheoEb TheoEb self-assigned this Jan 3, 2022
@TheoEb
Copy link

TheoEb commented Jan 3, 2022

What's the issue here ?
Should we fix the tests ? Sync with upstream ?

@EtienneM
Copy link
Member Author

EtienneM commented Jan 3, 2022

The specs are failing and I had no time to understand why. You should have a look at the specs and try to understand why they fail.

@TheoEb
Copy link

TheoEb commented Jan 4, 2022

From what I understand, there is the library docker/docker that uses a vendor.conf file, and go mod don't care about it, so we have some dependencies that have not the right version.
I tried to disable go modules for this project (seems working) but it's not the best solution.

@EtienneM EtienneM assigned EtienneM and unassigned TheoEb Jan 4, 2022
@EtienneM EtienneM force-pushed the fix/ioutil_deprecation branch 2 times, most recently from c16a1f4 to 3d0df29 Compare January 4, 2022 13:05
@EtienneM EtienneM marked this pull request as ready for review January 6, 2022 10:47
curzolapierre
curzolapierre approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TheoEb
TheoEb reviewed Jan 6, 2022
View reviewed changes
go.mod Outdated
@@ -1,5 +1,5 @@
module github.com/Scalingo/go-plugins-helpers

go 1.15
go 1.16

replace github.com/Sirupsen/logrus v1.7.0 => github.com/sirupsen/logrus v1.7.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency got renamed from Sirupsen to sirupsen a while back and it caused a mess in many Go projects around the world.

But you're right, we may not need it in this project. Let me check that.

The comprehensive answer is here: sirupsen/logrus#570 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it in b60c82e

@EtienneM EtienneM merged commit 41f2f5e into master Jan 6, 2022
@EtienneM EtienneM deleted the fix/ioutil_deprecation branch January 6, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheoEb TheoEb TheoEb left review comments

@curzolapierre curzolapierre curzolapierre approved these changes

Assignees

@EtienneM EtienneM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EtienneM @TheoEb @curzolapierre