-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace use of the deprecated ioutil package #3
Conversation
c858bd5
to
5e33bb3
Compare
What's the issue here ? |
The specs are failing and I had no time to understand why. You should have a look at the specs and try to understand why they fail. |
From what I understand, there is the library docker/docker that uses a |
c16a1f4
to
3d0df29
Compare
…o modules" This reverts commit 2857129.
3d0df29
to
54275de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
go.mod
Outdated
@@ -1,5 +1,5 @@ | |||
module github.com/Scalingo/go-plugins-helpers | |||
|
|||
go 1.15 | |||
go 1.16 | |||
|
|||
replace github.com/Sirupsen/logrus v1.7.0 => github.com/sirupsen/logrus v1.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency got renamed from Sirupsen
to sirupsen
a while back and it caused a mess in many Go projects around the world.
But you're right, we may not need it in this project. Let me check that.
The comprehensive answer is here: sirupsen/logrus#570 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it in b60c82e
Wait for #5 to be merged