filter tests to save time on terraform-only PRs #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydentherapper
previously approved these changes
Jul 25, 2023
haydentherapper
previously approved these changes
Jul 25, 2023
hectorj2f
reviewed
Jul 31, 2023
hack/setup-kind.sh
Outdated
| @@ -174,8 +174,8 @@ kubeadmConfigPatches: | |||
| "service-account-signing-key-file": "/etc/kubernetes/pki/sa.key" | |||
| "service-account-api-audiences": "api,spire-server" | |||
| "service-account-jwks-uri": "https://kubernetes.default.svc/openid/v1/jwks" | |||
| networking: | |||
| dnsDomain: "${CLUSTER_SUFFIX}" | |||
| # networking: | |||
There was a problem hiding this comment.
Why are we commenting this now ?
hectorj2f
reviewed
Jul 31, 2023
.github/workflows/test-release.yaml
Outdated
| @@ -52,9 +55,10 @@ jobs: | |||
|
|
|||
| - name: Setup Cluster | |||
| # TODO: update after next release. | |||
| uses: chainguard-dev/actions/setup-kind@52eca3baf7c09ec1dbc4195449779fa59cc618e6 | |||
| uses: bobcallaway/cg-actions/setup-kind@f807492463bc85bc56ddbac9ddc265e3caa4c8ce | |||
There was a problem hiding this comment.
why do we need to use this ?
|
@bobcallaway I am facing the same issue, happy to help fixing it! I was looking at #704 or #705 after talking with @wlynch. |
|
Since this is fixing the bug of not running tests unnecessarlly, I'm wondering if we should consider:
|
Signed-off-by: Bob Callaway <bcallaway@google.com>
bobcallaway
changed the title
hectorj2f
approved these changes
Aug 9, 2023
bobcallaway
added a commit
to sigstore/community
that referenced
this pull request
Aug 13, 2023
sigstore/scaffolding#715 changed the test behavior of `scaffolding` to optionally only run certain tests on terraform vs non-terraform PRs Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
cpanato
pushed a commit
to sigstore/community
that referenced
this pull request
Aug 14, 2023
sigstore/scaffolding#715 changed the test behavior of `scaffolding` to optionally only run certain tests on terraform vs non-terraform PRs Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
cpanato
pushed a commit
to sigstore/community
that referenced
this pull request
Aug 14, 2023
sigstore/scaffolding#715 changed the test behavior of `scaffolding` to optionally only run certain tests on terraform vs non-terraform PRs Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
Gregory-Pereira
pushed a commit
to Gregory-Pereira/scaffolding
that referenced
this pull request
Nov 16, 2023
Signed-off-by: Bob Callaway <bcallaway@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change adds
paths-ignorefilters to make terraform-only changes run fasterFixes: #699