add apiVersion field for ClusterConfiguration #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
|
also I see #173 but i'm not sure it is still working the same in 0.20.0 as it was in 0.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wlynch @vaikas as best as I can tell, this is the root cause of the flakiness we're observed of late in sigstore/scaffolding. the
apiVersionstring is set in https://github.com/sigstore/scaffolding/blob/2221b2ecb9a1d64896dd042bebacd3668fd456fb/hack/setup-kind.sh#L166, and given the note in https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta3/#kubeadm-k8s-io-v1beta3-ClusterConfiguration where it states "kubeadm v1.22.x and newer no longer support v1beta1 and older APIs", I suspect that without this string that the patch fails to successfully translate.sigstore/scaffolding#715 if you'd like to see me wrestle this to the ground via GHA ping-pong.