Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pre-existing secrets for CTLog. #429

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Oct 18, 2022

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Summary

Because we've added keys to TUF already, we can't create them and then add them, we need to take the pre-existing
private key and then reuse that for creating CTLog config.

Release Note

  • Add support for createctconfig to read a pre-existing private key to use for creating CTLog configuration.

Documentation

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll let someone with more knowledge of scaffolding approve

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas vaikas merged commit 38c958a into sigstore:main Oct 18, 2022
@vaikas vaikas deleted the pre-existing-keys branch October 18, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants