Add flags for bringing in existing private key. fix secret names to b… #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e consistent. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
| @@ -92,6 +92,10 @@ createctconfig: | |||
| logPrefix: sigstorescaffolding | |||
| privateKeyPasswordSecretName: "" | |||
| ttlSecondsAfterFinished: 3600 | |||
| pubkeysecret: "ctlog-public-key" | |||
There was a problem hiding this comment.
Are these just defaults? Does this value exist in prod?
There was a problem hiding this comment.
Yeah, these are just the defaults 👍
haydentherapper
previously approved these changes
Oct 18, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
priyawadhwa
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e consistent.
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Description of the change
Add flags for bringing in an existing secret.
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.