Restore obsolete inheritance-based API #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se() for legacy sinks (using the inheritance API); also now ensures the wrapped sink is disposed whether the wrapper started or not
nblumhardt
commented
Sep 15, 2022
| // override something like `DisposeAsyncCore()`; we just forward to the synchronous | ||
| // `Dispose()` method to ensure whatever cleanup they do still occurs. | ||
| Dispose(true); | ||
| return; |
There was a problem hiding this comment.
This was the original stumbling block that prevented me from enabling IAsyncDispose along with the legacy inheritance-based API.
Closed
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.0.0 removed the inheritance-based API; I think this was too hasty - although the corresponding functions/constructors were marked obsolete two years ago, that change didn't make it into a public release until around eight months ago, which hasn't allowed for enough actively-used but slow-moving sinks to migrate.
This change also ensures the wrapped sink is disposed whether the wrapper started or not; the original behavior (not disposing if
!_started) is undesirable/unexpected, as far as I can see.