You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Is this an issue related to the Serilog core project or one of the sinks or community projects.
This issue list is intended for Serilog Elasticsearch Sink issues. If this issue relates to another sink or to the code project,
please log on the related repository. Please use Gitter chat and Stack Overflow for discussions and questions.
Does this issue relate to a new feature or an existing bug?
Bug
New Feature
What version of Serilog.Sinks.Elasticsearch is affected? Please list the related NuGet package.
All up to 8.4.1
Please describe the current behavior? PeriodicBatchingSink has become sealed with 3.0.0, so the ElasticSearchSink cannot inherit from it. I believe the intended use is to implement IBatchedLogEventSink and pass it to an internal PeriodicBatchingSink instead.
Please describe the expected behavior?
Error on initialization after updating Serilog.Sinks.PeriodicBatching because PeriodicBatchingSink is now sealed
If the current behavior is a bug, please provide the steps to reproduce the issue and if possible a minimal demo of the problem
The text was updated successfully, but these errors were encountered:
The 3.1.0-* dev builds now available revert this change; if anyone has a chance to check out that 3.1 works properly with this sink, we can publish it 👍
A few questions before you begin:
Does this issue relate to a new feature or an existing bug?
What version of Serilog.Sinks.Elasticsearch is affected? Please list the related NuGet package.
All up to 8.4.1
What is the target framework and operating system? See target frameworks & net standard matrix.
Please describe the current behavior?
PeriodicBatchingSink
has becomesealed
with 3.0.0, so the ElasticSearchSink cannot inherit from it. I believe the intended use is to implementIBatchedLogEventSink
and pass it to an internalPeriodicBatchingSink
instead.Please describe the expected behavior?
Error on initialization after updating
Serilog.Sinks.PeriodicBatching
becausePeriodicBatchingSink
is now sealedIf the current behavior is a bug, please provide the steps to reproduce the issue and if possible a minimal demo of the problem
The text was updated successfully, but these errors were encountered: