Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

PerodicBatchingSink is sealed starting from 3.0.0 #466

Closed
2 of 7 tasks
kanadaj opened this issue Sep 14, 2022 · 5 comments
Closed
2 of 7 tasks

PerodicBatchingSink is sealed starting from 3.0.0 #466

kanadaj opened this issue Sep 14, 2022 · 5 comments

Comments

@kanadaj
Copy link
Contributor

kanadaj commented Sep 14, 2022

A few questions before you begin:

Is this an issue related to the Serilog core project or one of the sinks or
community projects.
This issue list is intended for Serilog Elasticsearch Sink issues. If this issue relates to another sink or to the code project,
please log on the related repository. Please use Gitter chat and Stack Overflow for discussions and questions.

Does this issue relate to a new feature or an existing bug?

  • Bug
  • New Feature

What version of Serilog.Sinks.Elasticsearch is affected? Please list the related NuGet package.
All up to 8.4.1

What is the target framework and operating system? See target frameworks & net standard matrix.

  • netCore 2.0
  • netCore 1.0
  • 4.7
  • 4.6.x
  • 4.5.x

Please describe the current behavior?
PeriodicBatchingSink has become sealed with 3.0.0, so the ElasticSearchSink cannot inherit from it. I believe the intended use is to implement IBatchedLogEventSink and pass it to an internal PeriodicBatchingSink instead.

Please describe the expected behavior?
Error on initialization after updating Serilog.Sinks.PeriodicBatching because PeriodicBatchingSink is now sealed

If the current behavior is a bug, please provide the steps to reproduce the issue and if possible a minimal demo of the problem

@kanadaj
Copy link
Contributor Author

kanadaj commented Sep 14, 2022

Here is the relevant commit from Serilog.Sinks.PeriodicBatching: serilog/serilog-sinks-periodicbatching@6978889

kanadaj referenced this issue in serilog/serilog-sinks-periodicbatching Sep 14, 2022
@nblumhardt
Copy link
Contributor

@nblumhardt
Copy link
Contributor

The 3.1.0-* dev builds now available revert this change; if anyone has a chance to check out that 3.1 works properly with this sink, we can publish it 👍

@kanadaj
Copy link
Contributor Author

kanadaj commented Sep 27, 2022

Seems to work fine with the new 3.1.0 version

@kanadaj kanadaj closed this as completed Sep 27, 2022
@nblumhardt
Copy link
Contributor

Thanks @kanadaj 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants