Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeriodicBatchingSink Sealed #69

Closed
aplato opened this issue Mar 1, 2024 · 5 comments
Closed

PeriodicBatchingSink Sealed #69

aplato opened this issue Mar 1, 2024 · 5 comments

Comments

@aplato
Copy link

aplato commented Mar 1, 2024

The scope was changed again. I was inheriting from PeriodicBatchingSink. Several projects inherit from this class as well. I think this happened in 3.0.0 and was reverted in 3.1.*.

Is this intended behavior in 4.0 going forward or does it need to be reverted again?/

serilog-contrib/serilog-sinks-elasticsearch#466

@nblumhardt
Copy link
Member

PR'd a fix for this: serilog-contrib/serilog-sinks-elasticsearch#579 - thanks for the heads-up.

@nblumhardt
Copy link
Member

PR is merged. Does the latest prerelease build of Serilog.Sinks.Elasticsearch resolve this for you? Cheers!

@aplato
Copy link
Author

aplato commented Mar 6, 2024

All good. Thank you.

@Verdurakh
Copy link

I still have the same problem with Serilog.Sinks.Elasticsearch v 9.0.3
and Serilog.Sinks.PeriodicBatching v 4
Serilog v 3.1.1
where the PeriodicBatching is sealed.

what versions should I use to get this resolved?

Thanks

@nblumhardt
Copy link
Member

Hi @Verdurakh - I'm not sure where the Elastic sink pre-release packages go or what their schedule is, I'm not a maintainer there. Asking over on that repo would be the way to go. HTH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants