Persist analysis files on the background & in parallel #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, bloop would persist the analysis file on `shutDown`. However, this hook has been removed upstream in facebookarchive/nailgun#131. As a result, we take another (more resilient) strategy to persist the analysis file. We persist analysis file on the io pool after every `Interpreter` execution, without blocking the return of the request. All the logs are redirected to the nailgun server output.
jvican
added
enhancement
build server
jvican
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+ update to latest nailgun.
Previously, bloop would persist the analysis file on
shutDown.However, this hook has been removed upstream in
facebookarchive/nailgun#131.
As a result, we take another (more resilient) strategy to persist the
analysis file. We persist analysis file on the io pool after every
Interpreterexecution, without blocking the return of the request.All the logs are redirected to the nailgun server output.