This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Remove class reference from nailgun stats #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttsugriy
approved these changes
Mar 31, 2018
facebook-github-bot
pushed a commit
to facebook/buck
that referenced
this pull request
Mar 31, 2018
Summary: This brings in facebookarchive/nailgun#131 Reviewed By: styurin fbshipit-source-id: adc160b
|
+1 Please use a github issue to announce breaking changes like buck does. We use nailgun in other projects as well |
jvican
added a commit
to scalacenter/bloop
that referenced
this pull request
Apr 6, 2018
Previously, bloop would persist the analysis file on `shutDown`. However, this hook has been removed upstream in facebookarchive/nailgun#131. As a result, we take another (more resilient) strategy to persist the analysis file. We persist analysis file on the io pool after every `Interpreter` execution, without blocking the return of the request. All the logs are redirected to the nailgun server output.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nailgun keeps nail class in memory preventing garbage collector to destroy it when nail finishes. Use string instead of class for nail stats.
With that I am also stopping support for nailShutdown. It should be implemented as a separate nail if anyone wants it.