Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batch of last minute improvements #406

Merged
merged 4 commits into from
Mar 28, 2018
Merged

Add batch of last minute improvements #406

merged 4 commits into from
Mar 28, 2018

Commits on Mar 28, 2018

  1. Tell users to regenerate config files 

    ... if classpath options are missing.
    @jvican
    jvican committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    00f01ba View commit details
    Browse the repository at this point in the history

  2. Use build base directory to shorten paths

    @jvican
    jvican committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    a466dfe View commit details
    Browse the repository at this point in the history

  3. Allow messages to be null in recording logger 

    So that we know what's going on with spurious failures like:

```
[error] Test bloop.tasks.TestLoggingSpec.concurrentTestRunsHaveDifferentStreams failed: java.lang.NullPointerException: null, took 4.542 sec
[error]     at scala.collection.immutable.StringLike.stripSuffix(StringLike.scala:165)
[error]     at scala.collection.immutable.StringLike.stripSuffix$(StringLike.scala:164)
[error]     at scala.collection.immutable.StringOps.stripSuffix(StringOps.scala:29)
[error]     at bloop.logging.RecordingLogger.$anonfun$getMessages$1(RecordingLogger.scala:12)
[error]     at scala.collection.immutable.List.map(List.scala:287)
[error]     at bloop.logging.RecordingLogger.getMessages(RecordingLogger.scala:10)
[error]     at bloop.tasks.TestLoggingSpec.concurrentTestRunsHaveDifferentStreams(TestLoggingSpec.scala:52)
[error] ...
```
    @jvican
    jvican committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    1ac59f2 View commit details
    Browse the repository at this point in the history

  4. Turn anon exception in configuration format exception 

    So that output is prettier.
    @jvican
    jvican committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    1de9a95 View commit details
    Browse the repository at this point in the history