Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batch of last minute improvements #406

Merged
merged 4 commits into from
Mar 28, 2018
Merged

Add batch of last minute improvements #406

merged 4 commits into from
Mar 28, 2018

Conversation

jvican
Copy link
Contributor

@jvican jvican commented Mar 28, 2018

  1. Prettify exception reporting.
  2. Stringify null in RecordingLogger to catch spurious test errors in CI.
  3. Use build base directory to shorten paths.
  4. Tell users to regenerate configuration files if classpathOptions is missing.

All has been tested locally.

@jvican
Tell users to regenerate config files
00f01ba 
... if classpath options are missing.
@jvican
Use build base directory to shorten paths
a466dfe
@jvican
Allow messages to be null in recording logger
1ac59f2 
So that we know what's going on with spurious failures like:

```
[error] Test bloop.tasks.TestLoggingSpec.concurrentTestRunsHaveDifferentStreams failed: java.lang.NullPointerException: null, took 4.542 sec
[error]     at scala.collection.immutable.StringLike.stripSuffix(StringLike.scala:165)
[error]     at scala.collection.immutable.StringLike.stripSuffix$(StringLike.scala:164)
[error]     at scala.collection.immutable.StringOps.stripSuffix(StringOps.scala:29)
[error]     at bloop.logging.RecordingLogger.$anonfun$getMessages$1(RecordingLogger.scala:12)
[error]     at scala.collection.immutable.List.map(List.scala:287)
[error]     at bloop.logging.RecordingLogger.getMessages(RecordingLogger.scala:10)
[error]     at bloop.tasks.TestLoggingSpec.concurrentTestRunsHaveDifferentStreams(TestLoggingSpec.scala:52)
[error] ...
```
@jvican
Turn anon exception in configuration format exception
1de9a95 
So that output is prettier.
@jvican jvican added enhancement cli configuration format Assigned to any ticket or pull request that will change the configuration file format. labels Mar 28, 2018
@jvican jvican merged commit 24a4b06 into master Mar 28, 2018
@tgodzik tgodzik deleted the topic/protect-users branch September 7, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli configuration format Assigned to any ticket or pull request that will change the configuration file format. enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jvican