Remove clean terminal before file watching #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing misbehaviours in the terminals, because it sometimes cleans the screen right after the compilation logs are outputted, and therefore they are lost.
jvican
added
bug
|
I really don't know how to fix this otherwise. I'm making this temporary fix for now. Whomever gets this back into the repo will need to check that it doesn't cause a race condition. |
|
(I double checked a race condition is what happens because the compiler does update the class files.) |
Duhemm
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing misbehaviours in the terminals, because it sometimes
cleans the screen right after the compilation logs are outputted, and
therefore they are lost.
Fixes #379.