Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even watch file iterations do not trigger test or compile #379

Closed
MasseGuillaume opened this issue Mar 16, 2018 · 0 comments
Closed

Even watch file iterations do not trigger test or compile #379

MasseGuillaume opened this issue Mar 16, 2018 · 0 comments
Assignees
@jvican
Labels
bug A defect or misbehaviour. task / watch

Comments

@MasseGuillaume
Copy link
Contributor

MasseGuillaume commented Mar 16, 2018 •
edited
Loading

out2

steps:

bloop test -w test-project-name
edit a file
save // 1
nothing happens
edit a file
save // 2
tests are run

expected:

tests should be triggered the first time I save.
@jvican jvican changed the title watch triggers test only after saving twice Show bloop logs in all file watching iterations Mar 16, 2018
@jvican jvican added task / watch bug A defect or misbehaviour. labels Mar 16, 2018
@jvican jvican self-assigned this Mar 16, 2018
@MasseGuillaume MasseGuillaume changed the title Show bloop logs in all file watching iterations --watch does not triggers test or compile. Mar 16, 2018
@jvican jvican mentioned this issue Mar 16, 2018
Merged
@jvican jvican changed the title --watch does not triggers test or compile. Some watch file iterations do not trigger test or compile Mar 16, 2018
@jvican jvican reopened this Mar 16, 2018
@jvican jvican changed the title Some watch file iterations do not trigger test or compile Even watch file iterations do not trigger test or compile Mar 22, 2018
jvican added a commit that referenced this issue Mar 23, 2018
@jvican
Ensure that file watching task exits
3b07914 
Previously, `cancel` would not complete the task. This refactoring makes
sure that the task is cancelled and that the completion returns the last
state processed by the consumer.

Such improvement makes sure that there's no hanging task listening to
file watching events.

Fixes #379.
@jvican jvican mentioned this issue Mar 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvican jvican

Labels
bug A defect or misbehaviour. task / watch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MasseGuillaume @jvican