Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitignored dist folder and updated gitigore files #804

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Gitignored dist folder and updated gitigore files #804

merged 3 commits into from
Apr 8, 2024

Conversation

rin-st
Copy link
Collaborator

@rin-st rin-st commented Apr 8, 2024

Description

Gitignored dist folder and updated gitigore files

Additional Information

technophile-04
technophile-04 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@technophile-04 technophile-04 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm @rin-st !!

Had this in my mind from so long but I have been always procrastinating :(

Also removed .vercel from root .gitignore at 572b3ca, I forgot to remove it at #780 where .vercel dir is created inside packages/nextjs

@technophile-04 technophile-04 merged commit b682091 into main Apr 8, 2024
1 check passed
@technophile-04 technophile-04 deleted the gitignore-dist branch April 8, 2024 16:37
@technophile-04 technophile-04 mentioned this pull request Apr 16, 2024
Merged
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technophile-04 technophile-04 technophile-04 approved these changes

@damianmarti damianmarti Awaiting requested review from damianmarti

@carletex carletex Awaiting requested review from carletex

@Pabl0cks Pabl0cks Awaiting requested review from Pabl0cks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rin-st @technophile-04