-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vercel deployment linking from github #780
Conversation
How to test it properly?
|
This should actually fail, If you try doing : And then connecting the repo to vercel it gives the above error. For example I tried doing same here
I just did Testing these changes :Maybe you could "Create a new template" and then push this PR changes to your repo of |
Thank you! Tried both cases and everything works like you said. Not sure why yesterday npx create-eth didn't work
But after adding se-2 as a third party repo from vercel, deployment still works for main. I think it's not a problem though Gj! |
@technophile-04 I was able to deploy to Vercel with no issues! |
Tested after merge and is working great for me, gj @technophile-04! 🙌 |
Description
After we merged #757 , it seems to broke the vercel deployment when you connect it through github example :
github.com/technophile-04/test-vercel-deployments
This is because we are mentioning
outputDir
invercel.json
which is different when you connect through github