Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vercel deployment linking from github #780

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

technophile-04
Copy link
Collaborator

Description

After we merged #757 , it seems to broke the vercel deployment when you connect it through github example :
github.com/technophile-04/test-vercel-deployments

Screenshot 2024-03-17 at 1 31 32 PM

This is because we are mentioning outputDir in vercel.json which is different when you connect through github

@rin-st
Copy link
Collaborator

rin-st commented Mar 17, 2024

How to test it properly?

  • Cloned main repo (add third party repo option), added it from vercel dashboard - deployment works already from main branch
  • npx create-eth@latest hardhat - same error on main branch, and same error when I add your changes.

@technophile-04 technophile-04 changed the title Revert #757 and use yarn as install command fix: vercel deployment linking from github Mar 18, 2024
@technophile-04
Copy link
Collaborator Author

added it from vercel dashboard - deployment works already from main branch

This should actually fail, If you try doing :

Screenshot 2024-03-18 at 12 51 56 PM

And then connecting the repo to vercel it gives the above error. For example I tried doing same here

npx create-eth@latest hardhat - same error on main branch, and same error when I add your changes.

I just did npx create-eth@latest hardhat and added this changes to it and it worked for example here


Testing these changes :

Maybe you could "Create a new template" and then push this PR changes to your repo of main branch and connect to github

@rin-st
Copy link
Collaborator

rin-st commented Mar 18, 2024

Thank you! Tried both cases and everything works like you said. Not sure why yesterday npx create-eth didn't work

Cloned main repo (add third party repo option), added it from vercel dashboard - deployment works already from main branch

But after adding se-2 as a third party repo from vercel, deployment still works for main. I think it's not a problem though

Gj!

@carletex carletex merged commit 892d229 into main Mar 19, 2024
1 check passed
@carletex carletex deleted the vercel-deployments branch March 19, 2024 11:08
@damianmarti
Copy link
Collaborator

@technophile-04 I was able to deploy to Vercel with no issues!

@Pabl0cks
Copy link
Collaborator

Tested after merge and is working great for me, gj @technophile-04! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants