Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize displaying of address and follow ERC-55 #734

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Standardize displaying of address and follow ERC-55 #734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75efb63
Fixes issue #733
tjayrush Feb 19, 2024
636e01e
import isENS
technophile-04 Feb 20, 2024
62461b9
update slice to 0,6
technophile-04 Feb 20, 2024
053ef25
use checkSumAddress for Address component and Raibowkit btn
technophile-04 Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nextjs/components/scaffold-eth/Address.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export const Address = ({ address, disableAddressLink, format, size = "base" }:
}

const blockExplorerAddressLink = getBlockExplorerAddressLink(targetNetwork, address);
let displayAddress = address?.slice(0, 5) + "..." + address?.slice(-4);
let displayAddress = address?.slice(0, 6) + "..." + address?.slice(-4);

if (ens) {
displayAddress = ens;
Expand Down
4 changes: 3 additions & 1 deletion ...ages/nextjs/components/scaffold-eth/RainbowKitCustomConnectButton/AddressInfoDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ export const AddressInfoDropdown = ({
<details ref={dropdownRef} className="dropdown dropdown-end leading-3">
<summary tabIndex={0} className="btn btn-secondary btn-sm pl-0 pr-2 shadow-md dropdown-toggle gap-0 !h-auto">
<BlockieAvatar address={address} size={30} ensImage={ensAvatar} />
<span className="ml-2 mr-1">{displayName}</span>
<span className="ml-2 mr-1">
{isENS(displayName) ? displayName : address?.slice(0, 5) + "..." + address?.slice(-4)}
technophile-04 marked this conversation as resolved.
Show resolved Hide resolved
</span>
<ChevronDownIcon className="h-6 w-4 ml-2 sm:ml-0" />
</summary>
<ul
Expand Down