Standardize displaying of address and follow ERC-55 #734
Conversation
|
TYSM for tackling this @tjayrush to add consistency to our shortened addresses 🔥 Added a couple of issues to check at my review 🙌 |
packages/nextjs/components/scaffold-eth/RainbowKitCustomConnectButton/AddressInfoDropdown.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @tjayrush and @Pabl0cks for review 🙌
Just pushed a small commit to show same format address at 053ef25 by using viem's getAddress which also seems a convention followed by metamask and other wallet 🙌 . I remember us discussing about this
| Before | After |
|---|---|
check out the 4th "F" in both image
There was a problem hiding this comment.
Looking good to me! GJ @tjayrush and @technophile-04 !
Just pushed a small commit to show same format address at 053ef25 by using viem's getAddress which also seems a convention followed by metamask and other wallet 🙌 . I remember us discussing about this
Really good one! 🔥
technophile-04
changed the title
Description
Closes the issue by make both displays of the address 0x1234...1234
Additional Information
Related Issues
_Closes #733
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: trueblocks.eth