Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly CLI backmerge #674

Merged
merged 7 commits into from
Dec 29, 2023
Merged

Weekly CLI backmerge #674

merged 7 commits into from
Dec 29, 2023

Conversation

technophile-04
Copy link
Collaborator

Description

tested it nicely and works great 🙌

Note: We shouldn't squash & merge this instead do a normal merge

rin-st
rin-st approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Pabl0cks
Pabl0cks approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both features working nicely on my fresh CLI generated project. GJ Shiv!! 🙌🙌

@technophile-04
Copy link
Collaborator Author

Thanks all 🙌 Just removed .github/ISSUE_TEMPLATE and pr template as commented #661 (comment) and they were kind of specific to SE-2

@technophile-04 technophile-04 merged commit 7cbd2be into cli Dec 29, 2023
@technophile-04 technophile-04 deleted the cli-backmerge branch December 29, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rin-st rin-st rin-st approved these changes

@Pabl0cks Pabl0cks Pabl0cks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@technophile-04 @rin-st @Pabl0cks @sverps