-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add external flag to external contracts #647
Conversation
Tysm @sverps, I think the approach makes sense I also tried dry running through merge logic, and looks good to me ! Regarding displaying on UI what if we do this : Just add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BarsArrowUpIcon | ExclamationCircle |
---|---|
Yeah the ExclamationCircle looks a bit too aggressive / kind of give the warning sense not to interact with that contract 😅, especially in light mode. BarsArrowUpIcon seems more subtle and decent.
Keeping it BarsArrowUpIcon for now but we can always change it later if ExclamationCircle make more sense or we find something better 🙌
Merging this tysm all 🙌 !!
Fixes #636
During the contracts deepMerge we can add
{ external: true }
to contracts that are declared in theexternalContracts.ts
file.This can be used to make UI modifications based on this flag (UI part is WIP)