Update wagmi to latest version #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it removes the ledger packages that are compromised
carletex
requested review from
technophile-04,
rin-st,
damianmarti and
Pabl0cks
|
We should create the NPX back-merge after merging this. |
technophile-04
approved these changes
Dec 14, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks lke the LedgerConnector (@ledgerhq/connect-kit-loader) has been compromised
Context:
https://twitter.com/wevm_dev/status/1735289737185837303
https://twitter.com/bantg/status/1735279127752540465
We don't use it on SE2 (we just use Rainbow's kit LedgerWallet) so we should be fine.
In any case, updating wagmi with the last version (where they remove the dependency): wevm/wagmi@53ca1f7