Skip to content

Commit

Permalink
fix(connectors): remove ledger due to security vulnerability
Browse files Browse the repository at this point in the history
  • Loading branch information
tmm committed Dec 14, 2023
1 parent e69f317 commit 53ca1f7
Show file tree
Hide file tree
Showing 21 changed files with 15 additions and 688 deletions.
7 changes: 7 additions & 0 deletions .changeset/grumpy-pears-obey.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@wagmi/connectors": patch
"@wagmi/core": patch
"wagmi": patch
---

Removed LedgerConnector due to security vulnerability
1 change: 0 additions & 1 deletion docs/pages/core/connectors/_meta.en-US.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"injected": "Injected",
"coinbaseWallet": "Coinbase Wallet",
"ledger": "Ledger",
"metaMask": "MetaMask",
"mock": "Mock",
"safe": "Safe",
Expand Down
133 changes: 0 additions & 133 deletions docs/pages/core/connectors/ledger.en-US.mdx

This file was deleted.

1 change: 0 additions & 1 deletion docs/pages/react/connectors/_meta.en-US.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"injected": "Injected",
"coinbaseWallet": "Coinbase Wallet",
"ledger": "Ledger",
"metaMask": "MetaMask",
"mock": "Mock",
"safe": "Safe",
Expand Down
133 changes: 0 additions & 133 deletions docs/pages/react/connectors/ledger.en-US.mdx

This file was deleted.

7 changes: 0 additions & 7 deletions examples/_dev/src/pages/_app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { avalanche, goerli, mainnet, optimism } from 'wagmi/chains'

import { CoinbaseWalletConnector } from 'wagmi/connectors/coinbaseWallet'
import { InjectedConnector } from 'wagmi/connectors/injected'
import { LedgerConnector } from 'wagmi/connectors/ledger'
import { MetaMaskConnector } from 'wagmi/connectors/metaMask'
import { SafeConnector } from 'wagmi/connectors/safe'
import { WalletConnectConnector } from 'wagmi/connectors/walletConnect'
Expand Down Expand Up @@ -51,12 +50,6 @@ const config = createConfig({
qrcode: true,
},
}),
new LedgerConnector({
chains,
options: {
projectId: process.env.NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID ?? '',
},
}),
new InjectedConnector({
chains,
options: {
Expand Down
1 change: 0 additions & 1 deletion packages/connectors/.gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Generated file. Do not edit directly.
coinbaseWallet/**
injected/**
ledger/**
metaMask/**
mock/**
safe/**
Expand Down
1 change: 0 additions & 1 deletion packages/connectors/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ const config = createConfig({

- [`CoinbaseWalletConnector`](/packages/connectors/src/coinbaseWallet.ts)
- [`InjectedConnector`](/packages/connectors/src/injected.ts)
- [`LedgerConnector`](/packages/connectors/src/ledger.ts)
- [`MetaMaskConnector`](/packages/connectors/src/metaMask.ts)
- [`MockConnector`](/packages/connectors/src/mock.ts)
- [`SafeConnector`](/packages/connectors/src/safe.ts)
Expand Down
6 changes: 0 additions & 6 deletions packages/connectors/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
},
"dependencies": {
"@coinbase/wallet-sdk": "^3.6.6",
"@ledgerhq/connect-kit-loader": "^1.1.0",
"@safe-global/safe-apps-provider": "^0.18.1",
"@safe-global/safe-apps-sdk": "^8.1.0",
"@walletconnect/ethereum-provider": "2.10.6",
Expand Down Expand Up @@ -47,10 +46,6 @@
"types": "./dist/injected.d.ts",
"default": "./dist/injected.js"
},
"./ledger": {
"types": "./dist/ledger.d.ts",
"default": "./dist/ledger.js"
},
"./metaMask": {
"types": "./dist/metaMask.d.ts",
"default": "./dist/metaMask.js"
Expand All @@ -76,7 +71,6 @@
"files": [
"/coinbaseWallet",
"/injected",
"/ledger",
"/metaMask",
"/mock",
"/safe",
Expand Down
Loading

2 comments on commit 53ca1f7

@vercel
Copy link

@vercel vercel bot commented on 53ca1f7 Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@such
Copy link

@such such commented on 53ca1f7 Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmm do you expect to restore the Ledger connector now that the vulnerability is fixed?

Please sign in to comment.