-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hardhat package plugins and add hardhat-verify #637
Update hardhat package plugins and add hardhat-verify #637
Conversation
Hey thanks @metoinside for this 🙌, I think there is some confusion with Some newer chains are not supported with Coming to this PR (using I like it since it supports newer chains (atleast I think chains that uses etherscan it support them without extra config nd by just updating api-key) 🙌
The only thing I don't like is update to verify command where you need to enter Maybe we should also add an programmatical verification example in cc @damianmarti @carletex for suggestions 🙌 Also incase if we don't go with |
Thanks @metoinside !! I think And yes! I think will be useful to add an example on how to add a verification with code in the deployment script. |
Update :
Once we merge this we can also a couple of lines about |
Thanks @metoinside and @technophile-04 ! Tested it and everything works fine! But I think we need to add additional script to package.json for verifying with |
Ohh yes! Added it at 2dc40bb, "verify": "hardhat etherscan-verify",
"hardhat-verify": "hardhat verify" Kept it like above, I think default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thanks all!
Also created an issue so we document it on the docs: scaffold-eth/se-2-docs#49
Great improvement!! Thanks! |
Description
As recorded with #314, we're unable to verify in some networks.
![image](https://private-user-images.githubusercontent.com/5622253/287371930-88b20165-8359-41df-bebb-b4be430d597e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUzNTIxMDAsIm5iZiI6MTcyNTM1MTgwMCwicGF0aCI6Ii81NjIyMjUzLzI4NzM3MTkzMC04OGIyMDE2NS04MzU5LTQxZGYtYmViYi1iNGJlNDMwZDU5N2UucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDNUMDgyMzIwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjBhYzYwYzMxMDk5MjIyYTU4Y2RlNDZjNTI5MDEwNDRlYTYwMGFkYjBmMzhiNjZlMmViN2NiNTJhYTc5YjFiNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.hmhcgN3d9F4A2zx6BCy4NHhNQ0Ys9mMRo6LD6OcxJCs)
It was returning an error as like below scrollSepolia, arbitrumSepolia, polygonZkEvmTestnet
That's because of
hardhat-etherscan
plugin which we're actively using and it is depreciated.Official docs are suggesting to migrate into
hardhat-verify
and this PR is trying to do it.As we migrated to the new library, we had to upgrade some dependencies and I tried to have a minimal impact.
For example, we can now deploy
sepolia
right away but we need to add custom configuration and the keys for thescrollSepolia
.It means after this PR is approved, we need to update the documentation on how to use it.
Additional Information
Related Issues
Closes #314
After this PR, you can now verify a smart contract with
yarn verify --network [networkOfYourChoice] <address> [constructorParameters]
We have verified these contracts
This is going to be my first PR, therefore please feel free to open a discussion or give feedback to improve
Your ENS/address: 0x63191383EDbd8531C442868d87555f1EA2f6ad4E