Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hardhat verify instead of hardhat etherscan-verify on yarn verify #314

Closed
damianmarti opened this issue Apr 20, 2023 · 3 comments · Fixed by #637
Closed

Use hardhat verify instead of hardhat etherscan-verify on yarn verify #314

damianmarti opened this issue Apr 20, 2023 · 3 comments · Fixed by #637
Labels
enhancement A nice to have, not critical

Comments

@damianmarti
Copy link
Collaborator

hardhat verify has more features, like linking to libraries.

@metoinside
Copy link
Contributor

Hello mates,

TLDR:

I didn't know hardhat-etherscan plugin depreciated, so I'm prooving below that why we need to move hardhat-verify, lol 😄


We can yarn verify successfully on polygonMumbai, sepolia etc.
However, we're unable to do the same in polygonZkEvmTestnet, arbitriumNova, scrollSepolia etc. networks.
This is something outside of the API keys issue as you may notice the error message is different.
telegram-cloud-photo-size-4-5976723026093391279-y


What might be the reason?

I learned that hardhat-etherscan supports the below list.
After reviewing it you'll better understand why the same contract verification

  • ✅ works on arbitriumGoerli
  • 🚫 but doesn't work for arbitrumSepolia and, others such as:
    • polygonZkEvm, polygonZkEvmTestnet, zkSync, zkSyncTestnet, base, baseGoerli, scroll, scrollSepolia
      • they don't overlap with the list of hardhat-etherscan therefore it returns the error
image

Anyway, if you are busy, I'm happy to take over this task to complete on my free time, @damianmarti and @austintgriffith

@damianmarti
Copy link
Collaborator Author

Hello mates,

TLDR:

I didn't know hardhat-etherscan plugin depreciated, so I'm prooving below that why we need to move hardhat-verify, lol 😄

We can yarn verify successfully on polygonMumbai, sepolia etc. However, we're unable to do the same in polygonZkEvmTestnet, arbitriumNova, scrollSepolia etc. networks. This is something outside of the API keys issue as you may notice the error message is different. telegram-cloud-photo-size-4-5976723026093391279-y

What might be the reason?

I learned that hardhat-etherscan supports the below list. After reviewing it you'll better understand why the same contract verification

  • ✅ works on arbitriumGoerli

  • 🚫 but doesn't work for arbitrumSepolia and, others such as:

    • polygonZkEvm, polygonZkEvmTestnet, zkSync, zkSyncTestnet, base, baseGoerli, scroll, scrollSepolia

      • they don't overlap with the list of hardhat-etherscan therefore it returns the error
image Anyway, if you are busy, I'm happy to take over this task to complete on my free time, @damianmarti and @austintgriffith

Yes, sure! Thanks!!

@metoinside
Copy link
Contributor

Today, I was able to verify two contracts on scrollSepolia and polygonZkEvmTestnet as an example with hardhat-verify. I learned quite a lot and below are the links of the contracts:

However, I noticed it requires quite a lot to update in existing libraries in order to use hardhat-verify therefore, I'll create the PR after having some housekeeping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A nice to have, not critical
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants