This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Simplify Node versions in Travis Ci #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous we manually installed NVM and did the version switching ourselves. This was required because Trvais didn't support NVM on OSX builds. This has since [been fixed][1] so lets see how it goes. [1:][travis-ci/travis-ci#2311]
|
I'm somewhat amazed this worked although builds appear to be slower. I'll rebuild later when the US is asleep and Travis' load is lower. |
|
It's still slower but not painfully slow. It's worth it for the reduction in complexity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous we manually installed NVM and did the version switching
ourselves. This was required because Travis didn't support NVM
on OSX builds. This has since been fixed so lets see how it
goes.