Update CI builds for NodeJS 6

[nschonni]

Blocked

• Node.js 6.0.0 appveyor/ci#770

[xzyfer]

Thanks. This will currently fail hard.

On 4/27/16, Nick Schonning notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

#1486

-- Commit Summary --

• Update CI builds for NodeJS 6

-- File Changes --

M .travis.yml (1)
M appveyor.yml (3)

-- Patch Links --

https://github.com/sass/node-sass/pull/1486.patch
https://github.com/sass/node-sass/pull/1486.diff

---

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#1486

Regards,
Michael

[nschonni]

Looks like Appveyor is passing because it doesn't understand the 6 version yet. Looking to see why

[nschonni]

Looks like AppVeyor will support it shortly appveyor/ci#770

[xzyfer]

I think the bigger problem is that node-sass just won't compile with node 6 yet. Every major node release invariably means we need to update the C/C++ binding code.

At the very least we'll need to update NAN.

[nschonni]

Yeah, someone pointed out in the other tread that NAN is still trying to figure out the issues raised by the depreciation messages.

[xzyfer]

To my amazement we compile fine on Node 6. I've started building some binaries.

[xzyfer]

@nschonni please update this to match the changes to .travis.yml in #1500.

[nschonni]

Rebased

[xzyfer]

Thanks. This is final blocker for 3.7.0.

[nschonni]

Realized that the AppVeyor config was spit between the tag and master builds. I added 6 to the master section and repushed

[roc]

Can't wait for 3.7.0! :-)

[xzyfer]

Looks like node 6 has shipped on appveyor. We have a failing test on node 7 Windows. Will take a closer look tomorrow. It looks race conditiony.

[saper]

I wonder if this didn't get solved in nodejs/node#5950 , after v6.0 release.
Actually, this was included in v6.0: nodejs/node@c43b182 , so maybe it broke it?

[xzyfer]

@saper I want to go ahead an ship 3.7.0 with the debug files, which means we don't need to subst. We can retroactively add the debug files when/if nodejs/node#6500 is suitably resolved.

Any objections?

[xzyfer]

Superseded by #1517 because of timezones.