Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly catch websocket CancelledError in websocket handler in Python 3.7 #2465

Open
wants to merge 2 commits into
base: 21.12LTS
Choose a base branch
from

Conversation

ashleysommer
Copy link
Member

@ashleysommer ashleysommer commented May 23, 2022

Apply fix #2463 to Sanic 21.12LTS version for python 3.7 users.

@ashleysommer ashleysommer requested a review from a team as a code owner May 23, 2022 23:01
@ashleysommer
Copy link
Member Author

I'm guessing we don't need to worry about the linter checks failing on this?

@ahopkins
Copy link
Member

That's odd... I wonder why that is? I am assuming it must be a versioning issue. But yes, I do not care about that.

@ashleysommer
Copy link
Member Author

Black check failing:

...
would reformat sanic/config.py
...
would reformat sanic/headers.py
...

Maybe a newer version of black used now than in December release?
Or maybe some patches were pushed to 21.12LTS branch previously that broke formatting.

@ahopkins
Copy link
Member

I think it is a black version issue. I have run into this on some other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants