Properly catch websocket CancelledError in websocket handler in Python 3.7 #2463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3.8
CancelledError
is subclass ofBaseException
, but in Python 3.7 and earlier, it is subclass ofException
. That means in python 3.7, theCancelledError
gets caught by the generalException
handler, and does not correctly handle the case of a cancelled websocket task.Fixes #2462