[4.0] Media Action plugins (joomla#29970)

* [4.0] Media Action plugins This PR does the following 1. removes unused strings 2. changes labelclass="d-none" to hiddenLabel in the xml 3. adds missing labels (even if they are not visible) ToDo in a later PR change the radio buttons in rotate to real buttons in a button group. The current code breaks accessibility but thats for another PR * xml
sakiss · Oct 16, 2020 · b008151 · b008151
1 parent e32eb9b
commit b008151
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 14 deletions.
diff --git a/administrator/language/en-GB/plg_media-action_crop.ini b/administrator/language/en-GB/plg_media-action_crop.ini
@@ -5,6 +5,7 @@
 
 PLG_MEDIA-ACTION_CROP="Media Action - Crop"
 PLG_MEDIA-ACTION_CROP_LABEL="Crop"
+PLG_MEDIA-ACTION_CROP_PARAM_ASPECT="Aspect Ratio"
 PLG_MEDIA-ACTION_CROP_PARAM_DEFAULT_RATIO="Default aspect ratio"
 PLG_MEDIA-ACTION_CROP_PARAM_HEIGHT="Height"
 PLG_MEDIA-ACTION_CROP_PARAM_LANDSCAPE="Landscape"

diff --git a/administrator/language/en-GB/plg_media-action_resize.ini b/administrator/language/en-GB/plg_media-action_resize.ini
@@ -6,12 +6,12 @@
 PLG_MEDIA-ACTION_RESIZE="Media Action - Resize"
 PLG_MEDIA-ACTION_RESIZE_BATCH_DESC="Settings for server side actions when images are created."
 PLG_MEDIA-ACTION_RESIZE_BATCH_LABEL="Batch Settings"
-PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_HEIGHT_DESC="The maximum height of an image to resize. When empty, no resizing is performed."
 PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_HEIGHT_LABEL="Image Max Height"
-PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_WIDTH_DESC="The maximum width of an image to resize. When empty, no resizing is performed."
 PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_WIDTH_LABEL="Image Max Width"
 PLG_MEDIA-ACTION_RESIZE_LABEL="Resize"
 PLG_MEDIA-ACTION_RESIZE_PARAM_HEIGHT="Height"
+PLG_MEDIA-ACTION_RESIZE_PARAM_HEIGHT_SLIDER="Height Slider"
 PLG_MEDIA-ACTION_RESIZE_PARAM_WIDTH="Width"
+PLG_MEDIA-ACTION_RESIZE_PARAM_WIDTH_SLIDER="Width Slider"
 PLG_MEDIA-ACTION_RESIZE_QUALITY="Quality"
 PLG_MEDIA-ACTION_RESIZE_XML_DESCRIPTION="Resize functionality for images."
diff --git a/administrator/language/en-GB/plg_media-action_rotate.ini b/administrator/language/en-GB/plg_media-action_rotate.ini
@@ -6,8 +6,6 @@
 PLG_MEDIA-ACTION_ROTATE="Media Action - Rotate"
 PLG_MEDIA-ACTION_ROTATE_LABEL="Rotate"
 PLG_MEDIA-ACTION_ROTATE_PARAM_ANGLE="Angle"
-PLG_MEDIA-ACTION_ROTATE_PARAM_DIRECTION="Direction"
-PLG_MEDIA-ACTION_ROTATE_PARAM_DIRECTION_LEFT="Left"
-PLG_MEDIA-ACTION_ROTATE_PARAM_DIRECTION_RIGHT="Right"
+PLG_MEDIA-ACTION_ROTATE_PARAM_BUTTONS="Angle Buttons"
 PLG_MEDIA-ACTION_ROTATE_QUALITY="Quality"
 PLG_MEDIA-ACTION_ROTATE_XML_DESCRIPTION="Adds rotate functionality for images."
diff --git a/plugins/media-action/crop/form/crop.xml b/plugins/media-action/crop/form/crop.xml
@@ -60,6 +60,7 @@
 		<field
 			name="aspectRatio"
 			type="groupedlist"
+			label="PLG_MEDIA-ACTION_CROP_PARAM_ASPECT"
 			hiddenLabel="true"
 			class="crop-aspect-ratio-options"
 			default="1.111"

diff --git a/plugins/media-action/resize/form/resize.xml b/plugins/media-action/resize/form/resize.xml
@@ -30,9 +30,9 @@
 		<field
 			name="resize_w"
 			type="range"
-			label=""
+			label="PLG_MEDIA-ACTION_RESIZE_PARAM_WIDTH_SLIDER"
 			value="0"
-			labelclass="d-none"
+			hiddenLabel="true"
 		/>
 
 		<field
@@ -53,9 +53,9 @@
 		<field
 			name="resize_h"
 			type="range"
-			label=""
+			label="PLG_MEDIA-ACTION_RESIZE_PARAM_HEIGHT_SLIDER"
 			value="0"
-			labelclass="d-none"
+			hiddenLabel="true"
 		/>
 	</fieldset>
 </form>
diff --git a/plugins/media-action/resize/resize.xml b/plugins/media-action/resize/resize.xml
@@ -19,7 +19,7 @@
 	</languages>
 	<config>
 		<fields name="params">
-			<fieldset 
+			<fieldset
 				name="batch"
 				label="PLG_MEDIA-ACTION_RESIZE_BATCH_LABEL"
 				description="PLG_MEDIA-ACTION_RESIZE_BATCH_DESC"
@@ -29,15 +29,13 @@
 					name="batch_width"
 					type="text"
 					label="PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_WIDTH_LABEL"
-					descripton="PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_WIDTH_DESC"
 					addonAfter="px"
 					filter="integer"
 				/>
 				<field
 					name="batch_height"
 					type="text"
 					label="PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_HEIGHT_LABEL"
-					descripton="PLG_MEDIA-ACTION_RESIZE_BATCH_MAX_HEIGHT_DESC"
 					addonAfter="px"
 					filter="integer"
 				/>

diff --git a/plugins/media-action/rotate/form/rotate.xml b/plugins/media-action/rotate/form/rotate.xml
@@ -30,8 +30,8 @@
 		<field
 			name="rotate_distinct"
 			type="radio"
-			hiddenLabel="true"
-			class="btn-group btn-group-rotate"
+			label="PLG_MEDIA-ACTION_ROTATE_PARAM_BUTTONS"
+			class="btn-group"
 			default=""
 			>
 			<option value="0">0</option>