[4.0] Media Action plugins #29970
Merged
[4.0] Media Action plugins #29970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does the following 1. removes unused strings 2. changes labelclass="d-none" to hiddenLabel in the xml 3. adds missing labels (even if they are not visible) ToDo in a later PR change the radio buttons in rotate to real buttons in a button group. The current code breaks accessibility but thats for another PR
Quy
reviewed
Jul 4, 2020
|
I have tested this item ✅ successfully on 0a7ea69 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29970. |
1 similar comment
|
I have tested this item ✅ successfully on 0a7ea69 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29970. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29970. |
|
thanks |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* [4.0] Media Action plugins This PR does the following 1. removes unused strings 2. changes labelclass="d-none" to hiddenLabel in the xml 3. adds missing labels (even if they are not visible) ToDo in a later PR change the radio buttons in rotate to real buttons in a button group. The current code breaks accessibility but thats for another PR * xml
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following
ToDo in a later PR change the radio buttons in rotate to real buttons in a button group. The current code breaks accessibility but thats for another PR