Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use the new Client Gateway SDK #4082

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Refactor: use the new Client Gateway SDK #4082

wants to merge 1 commit into from

Conversation

katspaugh
Copy link
Member

What it solves

An initial implementation of the new Client Gateway SDK.

Feedback documented here: safe-global/safe-client-gateway-sdk#1

Copy link

github-actions bot commented Aug 21, 2024

Copy link

github-actions bot commented Aug 21, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Aug 21, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.48% (-0.01% 🔻)
11726/14941
🔴 Branches 58.92% 2981/5059
🟡 Functions
65.96% (-0.04% 🔻)
1876/2844
🟡 Lines
79.87% (-0.01% 🔻)
10572/13237
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / tokenTransferParams.ts
96.15% (-3.85% 🔻)
80%
80% (-20% 🔻)
95.65% (-4.35% 🔻)

Test suite run success

1456 tests passing in 201 suites.

Report generated by 🧪jest coverage report action from ba752e8

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/settings/setup 39.71 KB (🟡 +3.73 KB) 984.1 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@katspaugh katspaugh marked this pull request as draft September 9, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant