Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters and response types #1

Open
katspaugh opened this issue Aug 21, 2024 · 0 comments · May be fixed by #2
Open

Parameters and response types #1

katspaugh opened this issue Aug 21, 2024 · 0 comments · May be fixed by #2

Comments

@katspaugh
Copy link
Member

katspaugh commented Aug 21, 2024

I've implemented two SDK calls and the developer experience so far wasn't stellar. 😅

  1. Passing parameters is verbose. Why does the client need to know which params are path params and which are query?
  2. Response type seems to be buried in a larger FetchResponse type which is also quite verbose.
  3. It's not straightforward to match a function and its response type, you have to look in responses -> content.
  4. Some functions (e.g. getSupportedFiatCodes) return the data directly, some (e.g. getMasterCopies) wrap it in a { data, error } object. Ideally they should all return the data directly, and errors should be returned as proper HTTP errors.
Screenshot 2024-08-21 at 15 59 26 Screenshot 2024-08-21 at 16 11 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant