Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow recreating wasm event loop with spawn #2897

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Allow recreating wasm event loop with spawn #2897

merged 1 commit into from
Jun 23, 2023

Conversation

grovesNL
Copy link
Contributor

Rebased #2720

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

It seems to work after rebasing but haven't been able to test in detail yet. It looks like some other recent winit changes broke my canvas sizing so I need to look into that.

@grovesNL grovesNL requested a review from daxpedda as a code owner June 22, 2023 11:48
@daxpedda daxpedda self-assigned this Jun 22, 2023
daxpedda
daxpedda approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You said you still wanted to test this in detail, so I'm gonna hold off merging this until you are ready.

CHANGELOG.md Outdated Show resolved Hide resolved
@daxpedda daxpedda added the C - waiting on author Waiting for a response or another PR label Jun 22, 2023
@grovesNL
Copy link
Contributor Author

@daxpedda confirmed that it allows me to recreate the event loop, so this should be ready

@grovesNL
Copy link
Contributor Author

Rebased again for the changelog conflict

daxpedda
daxpedda approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@daxpedda daxpedda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This will still need another rebase though, sorry!

EDIT: tried it myself, but your fork is part of an organization, so I don't have access.

@grovesNL
Copy link
Contributor Author

@daxpedda thanks! Rebased

@daxpedda daxpedda merged commit bc216b8 into rust-windowing:master Jun 23, 2023
@daxpedda daxpedda mentioned this pull request Jun 25, 2023
Merged
@grovesNL grovesNL mentioned this pull request Jun 29, 2023
Open
@grovesNL grovesNL deleted the web-spawn-static branch August 1, 2023 12:29
@phisn phisn mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees

@daxpedda daxpedda

Labels
C - waiting on author Waiting for a response or another PR DS - web
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grovesNL @daxpedda