-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow context sharing for headless contexts on MacOS #1333
Conversation
Hi, I've rebased the PR on current Could somebody with permissions please approve the CI run and consider merging this? Thanks! |
I don't have the means to test this myself, so I'd be merging partially blind right now. If either of @mcginty @xiaopengli89 could get a repro on the bug and fix (I see you two have given this PR a "👍"), then that would help soothe my worries. |
Hi @maroider I've rebased on the latest |
The context sharing is enabled on macOS, however headless was removed in some sense, but you can create a context without a window, so it might be fine? |
@kchibisov I see things have changed a bit since I submitted this PR. I'll test out shared contexts on MacOS when I get the chance. If I can create a context without a window, I think that will suffice for my usage. Edit: Tested it out, context sharing seems to work well on MacOS! |
cargo fmt
has been run on this branchcargo doc
builds successfullyCHANGELOG.md
if knowledge of this change could be valuable to usersOriginal issue: #899
This was originally implemented in #1132, however sharing support was never added for headless contexts. This is essentially the same change as before, just in
new_headless
.I tested this in a company application which uses multi-threaded OpenGL contexts with texture sharing, and this change fixed an issue I was having. However, in
master
before this change,cargo run --example sharing
just showed a black screen. It also showed a black screen after this change, so I can't claim the example runs correctly. There's some other issue for MacOS at play for that.